fix(web): keep project favicon shape consistent across sizes - #11
Closed
sameerr03 wants to merge 10 commits into
Closed
fix(web): keep project favicon shape consistent across sizes#11sameerr03 wants to merge 10 commits into
sameerr03 wants to merge 10 commits into
Conversation
- Import native Codex history into T3 threads - Restore missing projections from imported event streams
…in GitHubPullRequestCli (pingdotgg#7385) Signed-off-by: aoright <102943475+aoright@users.noreply.github.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
The favicon used a fixed 6px radius, so the 12px tooltip icon rendered as a circle while the 16px sidebar icon rendered as a squircle. Use a proportional radius so every surface shows the same squircle. Made with Claude Fable 5.1 via Claude Code. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
github-actions
Bot
added
vouch:trusted
Keep the sidebar row favicon unchanged and give the thread tooltip and breadcrumb favicons the same radius-to-size ratio, so they read as the same squircle instead of circles. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The project favicon in the sidebar thread row is a squircle, but the same favicon in the thread hover tooltip and in the chat breadcrumb renders as a circle. All three use
ProjectFavicon, which applies a fixed 6pxrounded-smradius. That reads as a squircle at the sidebar's 16px size but collapses into a circle at the tooltip's 12px and the breadcrumb's 14px.Fix
Leave the component and the sidebar row untouched. Override the radius at the two call sites that looked wrong, using the same radius-to-size ratio the sidebar row already has (
rounded-[37.5%], i.e. 6/16), so the tooltip and breadcrumb favicons now match the sidebar squircle.Verification
Not run locally: the test runners are not on this machine's PATH. The existing
ProjectFavicon.test.tsxdoes not assert on the radius class. Relying on CI.Made with Claude Fable 5.1 via Claude Code.
🤖 Generated with Claude Code